Make ReadIndex work safely #2469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dna2github
pushed a commit
to dna2fork/dgraph
that referenced
this pull request
Jul 19, 2019
Fix a long-standing bug, where we were overwriting raftpb.Message.Context, before sending it over the wire. The understanding we had was that Context field was unused by raft library, but that was not the case. Specifically, MsgReadIndex was being sent as part of HeartBeat using the Context field. Changed the proto that we use for sending Raft message batches, so that it carries RaftContext directly, instead of making it part of the raftpb.Message. Turned linearizable reads back on for Zero, and for retrieving state from Zero. More context here: etcd-io/etcd#9893
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a long-standing bug, where we were overwriting
raftpb.Message.Context, before sending it over the wire. The understanding we had was that Context field was unused by raft library, but that was not the case. Specifically, MsgReadIndex was being sent as part of HeartBeat using the Context field.Changed the proto that we use for sending Raft message batches, so that it carries RaftContext directly, instead of making it part of the raftpb.Message.
Turned linearizable reads back on for Zero, and for retrieving state from Zero.
More context here: etcd-io/etcd#9893
This change is