Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Export to return Status and use simpler request #2741

Merged
merged 1 commit into from
Nov 8, 2018
Merged

Change Export to return Status and use simpler request #2741

merged 1 commit into from
Nov 8, 2018
+509 −590

Conversation

srfrog
Copy link
Contributor

@srfrog srfrog commented Nov 8, 2018 •
edited by manishrjain
Loading

This PR changes worker.Export() signature to use the new global pb.Status object and a simpler request object pb.ExportRequest.

This change is Reviewable

manishrjain
manishrjain approved these changes Nov 8, 2018
View reviewed changes
Copy link
Contributor

@manishrjain manishrjain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: Thanks for doing this!

Reviewed 4 of 4 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@srfrog srfrog merged commit 6b474ff into master Nov 8, 2018
@srfrog srfrog deleted the srfrog/simpler_export_api branch November 8, 2018 23:57
dna2github pushed a commit to dna2fork/dgraph that referenced this pull request Jul 19, 2019
@srfrog @dna2github
remove ExportPayload from protos. Export returns Status and ExportReq…
3a8ddcc 
…uest. (dgraph-io#2741)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manishrjain manishrjain manishrjain approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@srfrog @manishrjain