Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checking nil values in the equal function #2769

Merged
merged 2 commits into from
Nov 22, 2018
Merged

Checking nil values in the equal function #2769

merged 2 commits into from
Nov 22, 2018

Conversation

gitlw
Copy link

@gitlw gitlw commented Nov 21, 2018

fixes #2766


This change is Reviewable

Copy link
Contributor

@manishrjain manishrjain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: Thanks for fixing this quickly. Just ensure you don't cross 100 char limit.

Reviewed 2 of 2 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @gitlw and @danielmai)


types/sort_test.go, line 137 at r1 (raw file):

	// not equal when either parameter has the Value field being nil
	require.False(t, equal(Val{Tid: IntID, Value: int64(3)}, Val{Tid: IntID}), "equal should return false when either parameter cannot have its value converted")

100 char limit per line.

@gitlw gitlw merged commit 4786be3 into dgraph-io:master Nov 22, 2018
@gitlw gitlw deleted the null_value_check branch November 22, 2018 00:31
dna2github pushed a commit to dna2fork/dgraph that referenced this pull request Jul 19, 2019
* Checking nil values in the equal function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Query crashes dgraph
2 participants