Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add access control mechanism to Zero #2930

Closed
srfrog opened this issue Jan 24, 2019 · 3 comments
Closed

Add access control mechanism to Zero #2930

srfrog opened this issue Jan 24, 2019 · 3 comments
Labels
kind/feature Something completely new we should consider. priority/P3 Low priority, something to be done once everything else seems fixed.

Comments

@srfrog
Copy link
Contributor

srfrog commented Jan 24, 2019

There's no authentication, right? So even if the dgraph server was started by root, it can still be shut down by any user?

That's correct. We need to add some access control to Zero.

Originally posted by @srfrog in #2928 (comment)

@srfrog srfrog added kind/feature Something completely new we should consider. priority/P1 Serious issue that requires eventual attention (can wait a bit) priority/P3 Low priority, something to be done once everything else seems fixed. and removed priority/P1 Serious issue that requires eventual attention (can wait a bit) labels Jan 24, 2019
@Graphpinto
Copy link
Contributor

Couple of options here -

  1. Create a super user stored in config (with password hashed) during installation, and make the end point only callable by the super user
  2. Make the endpoint invokable only from local host and not from remote host

@codexnull
Copy link
Contributor

My thinking was to use TLS (aka SSL). Just require /admin requests to be done using a secure connection and that can only be established by presenting the right certificate. I was thinking most of the hard work in that case could be pushed down to the TLS/crypto libraries rather than dgraph itself.

Disclaimer: I have not actually looked into how feasible this would be.

@srfrog
Copy link
Contributor Author

srfrog commented Feb 12, 2019

Technically that is already done in the dgraph cert command. Just need to make a cert for zero but it hasn't been tested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Something completely new we should consider. priority/P3 Low priority, something to be done once everything else seems fixed.
Development

No branches or pull requests

4 participants