Issue: 2926 whitelist by hostname #2953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golangcibot
reviewed
Jan 30, 2019
dgraph/cmd/alpha/run.go
Outdated
| rangeHi := make(net.IP, len(rangeLo)) | ||
| copy(rangeHi, rangeLo) | ||
| for i := 1; i <= maskLen; i++ { | ||
| rangeHi[addrLen - i] |= ^network.Mask[maskLen - i] |
There was a problem hiding this comment.
File is not goimports-ed (from goimports)
manishrjain
approved these changes
Jan 30, 2019
There was a problem hiding this comment.
Reviewed 2 of 2 files at r2.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @codexnull, @golangcibot, and @srfrog)
dgraph/cmd/alpha/run.go, line 231 at r2 (raw file):
rangeLo := net.ParseIP(tuple[0]) rangeHi := net.ParseIP(tuple[1]) if rangeLo == nil {
@srfrog would do a switch case here. Looks nicer as well.
srfrog
approved these changes
Jan 30, 2019
There was a problem hiding this comment.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @golangcibot and @manishrjain)
dgraph/cmd/alpha/run.go, line 231 at r2 (raw file):
Previously, manishrjain (Manish R Jain) wrote…
@srfrog would do a switch case here. Looks nicer as well.
yes, if more than one else case, i'd use a switch.
https://golang.org/doc/effective_go.html#switch
dna2github
pushed a commit
to dna2fork/dgraph
that referenced
this pull request
Jul 19, 2019
Changes: * Add support for whitelisting by * hostname * single IP address * CIDR block * IPv6 * Add IP string parsing test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2926. In addition to addrLo:addrHi ranges, support whitelisting by
This change is