Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename type predicate to dgraph.type #3204

Merged
merged 2 commits into from
Mar 26, 2019
Merged

Rename type predicate to dgraph.type #3204

merged 2 commits into from
Mar 26, 2019

Conversation

martinmr
Copy link
Contributor

@martinmr martinmr commented Mar 25, 2019 •
edited by manishrjain
Loading

This change is Reviewable

@martinmr martinmr requested a review from a team March 25, 2019 20:29
golangcibot
golangcibot reviewed Mar 25, 2019
View reviewed changes
x/keys.go Outdated Show resolved Hide resolved
codexnull
codexnull reviewed Mar 26, 2019
View reviewed changes
Copy link
Contributor

@codexnull codexnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 8 of 9 files at r1, 1 of 1 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @martinmr)

@martinmr martinmr merged commit 1f40701 into master Mar 26, 2019
@martinmr martinmr deleted the martinmr/rename-type branch March 26, 2019 20:44
dna2github pushed a commit to dna2fork/dgraph that referenced this pull request Jul 19, 2019
@martinmr @dna2github
Rename type predicate to dgraph.type (dgraph-io#3204)
6bb9aea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@golangcibot golangcibot golangcibot left review comments

@codexnull codexnull codexnull left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@martinmr @codexnull @golangcibot