Update live loader flag help text. #3278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The live loader can already take in multiple Dgraph Alpha addresses to distribute the load across the cluster during loading. The flag help text makes this option clear.
golangcibot
reviewed
Apr 10, 2019
dgraph/cmd/live/run.go
Outdated
| @@ -87,7 +87,7 @@ func init() { | |||
| flag.StringP("files", "f", "", "Location of *.rdf(.gz) or *.json(.gz) file(s) to load") | |||
| flag.StringP("schema", "s", "", "Location of schema file") | |||
| flag.String("format", "", "Specify file format (rdf or json) instead of getting it from filename") | |||
| flag.StringP("dgraph", "d", "127.0.0.1:9080", "Dgraph alpha gRPC server address") | |||
| flag.StringP("dgraph", "d", "127.0.0.1:9080", "Comma-separated list of Dgraph alpha gRPC server addresses") | |||
codexnull
approved these changes
Apr 10, 2019
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @danielmai)
manishrjain
approved these changes
Apr 10, 2019
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @danielmai)
MichelDiz
added a commit
that referenced
this pull request
Apr 12, 2019
dna2github
pushed a commit
to dna2fork/dgraph
that referenced
this pull request
Jul 19, 2019
The live loader can already take in multiple Dgraph Alpha addresses to distribute the load across the cluster during loading. The flag help text makes this option clear.
dna2github
pushed a commit
to dna2fork/dgraph
that referenced
this pull request
Jul 19, 2019
* Docs: Distributed Load and change increment flag Added about distributed load related to dgraph-io#3278 Change in increment section is related to dgraph-io#3284 * docs: Update description for live loader's alpha flag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The live loader can already take in multiple Dgraph Alpha addresses to
distribute the load across the cluster during loading. The flag help text makes
this option clearer.
This change is