Fix tablet error handling. #3323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently errUnservedTablet is being returned when there's an issue with the tablets. However, there are actually two types of errors that should be handled differently. 1. Predicate has not been seen yet so the tablet group id is zero. 2. The group id of the tablet is > 0 but it differs from the id of the current group. This change fixes the error handling. The error running in the move-tablet jepsen test is fixed by it.
manishrjain
approved these changes
Apr 25, 2019
There was a problem hiding this comment.
Reviewed 7 of 7 files at r1.
Reviewable status: 2 of 7 files reviewed, 1 unresolved discussion (waiting on @manishrjain and @martinmr)
worker/mutation.go, line 44 at r1 (raw file):
ErrNonExistentTabletMessage = "Requested predicate is not being served by any tablet" errUnservedTablet = x.Errorf("Tablet isn't being served by this instance") errNonexistentTablet = x.Errorf(ErrNonExistentTabletMessage)
Move this up to be placed right below the message.
martinmr
commented
Apr 25, 2019
There was a problem hiding this comment.
Reviewable status: 2 of 7 files reviewed, 1 unresolved discussion (waiting on @manishrjain)
worker/mutation.go, line 44 at r1 (raw file):
Previously, manishrjain (Manish R Jain) wrote…
Move this up to be placed right below the message.
Done.
dna2github
pushed a commit
to dna2fork/dgraph
that referenced
this pull request
Jul 19, 2019
Currently errUnservedTablet is being returned when there's an issue with the tablets. However, there are actually two types of errors that should be handled differently. 1. Predicate has not been seen yet so the tablet group id is zero. 2. The group id of the tablet is > 0 but it differs from the id of the current group. This change fixes the error handling. The error running in the move-tablet jepsen test is fixed by it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently errUnservedTablet is being returned when there's an issue with
the tablets. However, there are actually two types of errors that should
be handled differently.
current group.
This change fixes the error handling. The error in the move-tablet jepsen
test is fixed by it.
This change is