Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix user meta of schema and type entries in bulk loader. #3628

Merged
merged 1 commit into from
Jul 11, 2019

Conversation

martinmr
Copy link
Contributor

@martinmr martinmr commented Jul 3, 2019

The user meta should not be BitCompletePosting since that indicates the
value is a posting list.


This change is Reviewable

The user meta should not be BitCompletePosting since that indicates the
value is a posting list.
@martinmr martinmr requested review from manishrjain and a team as code owners July 3, 2019 19:14
@campoy
Copy link
Contributor

campoy commented Jul 3, 2019

Was there an issue for this? Please link it on the PR description with a Fixes #xxx

@martinmr
Copy link
Contributor Author

martinmr commented Jul 3, 2019

No issue for this. I was looking at another issue when I noticed this.

Copy link
Contributor

@manishrjain manishrjain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@danielmai
Copy link
Contributor

danielmai commented Jul 11, 2019

Would this fix #3607?
Edit: It does not.

@martinmr
Copy link
Contributor Author

No. I found this issue while investigating that issue but it's not the fix.

@martinmr martinmr merged commit 3590a40 into master Jul 11, 2019
@martinmr martinmr deleted the martinmr/bulk-schema-meta branch July 11, 2019 21:54
dna2github pushed a commit to dna2fork/dgraph that referenced this pull request Jul 19, 2019
)

The user meta should not be BitCompletePosting since that indicates the
value is a posting list.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants