Fix StreamWriter usage in bulk loader #3635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…phase. This PR fixes that.
golangcibot
reviewed
Jul 5, 2019
| var listSize int | ||
| list := &bpb.KVList{} | ||
|
|
||
| preds := make(map[string]uint32) | ||
| setStreamId := func(kv *bpb.KV) { |
There was a problem hiding this comment.
var setStreamId should be setStreamID (from golint)
|
|
||
| // We don't need to consider the data prefix, count prefix, etc. because each predicate has | ||
| // a list of sorted keys the way they are produced. | ||
| streamId := preds[pk.Attr] |
There was a problem hiding this comment.
var streamId should be streamID (from golint)
manishrjain
commented
Jul 5, 2019
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @golangcibot)
dgraph/cmd/bulk/reduce.go, line 146 at r1 (raw file):
Previously, golangcibot (Bot from GolangCI) wrote…
var
setStreamIdshould besetStreamID(fromgolint)
Ignoring.
dgraph/cmd/bulk/reduce.go, line 152 at r1 (raw file):
Previously, golangcibot (Bot from GolangCI) wrote…
var
streamIdshould bestreamID(fromgolint)
Ignoring.
dna2github
pushed a commit
to dna2fork/dgraph
that referenced
this pull request
Jul 19, 2019
Last remaining KVs were not getting their StreamId set during reduce phase. This PR fixes that. Fixes dgraph-io#3625 .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last remaining KVs were not getting their StreamId set during reduce phase. This PR fixes that.
Fixes #3625 .
This change is