Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

encoding_ns might not be accurate #3690

Closed
martinmr opened this issue Jul 19, 2019 · 2 comments
Closed

encoding_ns might not be accurate #3690

martinmr opened this issue Jul 19, 2019 · 2 comments
Assignees
@martinmr
Labels
area/performance Performance related issues. kind/bug Something is broken. status/accepted We accept to investigate/work on it.
Milestone
Dgraph v1.1

Comments

@martinmr
Copy link
Contributor

From #3668 the user reports that the value of encoding_ns is roughly 100ms from an AWS zone with a latency of 100ms. This probably means the transport time is being included as part of encoding_ns. If that's the case, Dgraph should be changed to report accurate stats. Possibly, that could involve adding another field called transport_ns to report the time taken to receive the response.
@martinmr martinmr self-assigned this Jul 19, 2019
@martinmr
Copy link
Contributor Author

Here's the culprit line:

l.Json = time.Since(l.Start) - l.Parsing - l.Processing

@martinmr
Copy link
Contributor Author

Submitted #3692 to fix the calculation. Still need another PR to report the transport time.

@campoy campoy added area/performance Performance related issues. kind/bug Something is broken. status/accepted We accept to investigate/work on it. labels Jul 19, 2019
@campoy campoy added this to the Dgraph v1.1 milestone Jul 19, 2019
This was referenced Jul 19, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@martinmr martinmr

Labels
area/performance Performance related issues. kind/bug Something is broken. status/accepted We accept to investigate/work on it.
Milestone
Dgraph v1.1
Development

Successfully merging a pull request may close this issue.

Add transport_ns value to query responses. dgraph-io/dgraph
2 participants
@martinmr @campoy