Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Raft heartbeat rate for Zero. #3753

Merged
merged 1 commit into from
Aug 6, 2019
Merged

Fix Raft heartbeat rate for Zero. #3753

merged 1 commit into from
Aug 6, 2019

Conversation

danielmai
Copy link
Contributor

@danielmai danielmai commented Aug 5, 2019 •
edited by manishrjain
Loading

In #3708 (4b41d9c) we bumped up the Raft
heartbeat rate to 100ms ticks. This change also updates the heartbeat ticker for
Zero too. Otherwise, Zero's election ticker would happen every 400ms instead of
every 2s as intended since raft.Config.ElectionTick is set to 20.

This change is Reviewable

@danielmai
Fix Raft heartbeat rate for Zero.
dd69562 
In #3708 (4b41d9c) we bumped up the Raft
heartbeat rate to 100ms ticks. This change also updates the heartbeat ticker for
Zero too. Otherwise, Zero's election ticker would happen every 400ms instead of
every 2s since raft.Config.ElectionTick is set to 20.
@danielmai danielmai requested review from manishrjain and a team as code owners August 5, 2019 21:01
@danielmai danielmai merged commit 9abaea4 into master Aug 6, 2019
@danielmai danielmai deleted the danielmai/zero-raft-ticker branch August 6, 2019 01:20
mangalaman93 pushed a commit that referenced this pull request Aug 29, 2019
@danielmai @mangalaman93
Fix Raft heartbeat rate for Zero. (#3753)
81be40b 
In #3708 (4b41d9c) we bumped up the Raft
heartbeat rate to 100ms ticks. This change also updates the heartbeat ticker for
Zero too. Otherwise, Zero's election ticker would happen every 400ms instead of
every 2s since raft.Config.ElectionTick is set to 20.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manishrjain manishrjain Awaiting requested review from manishrjain

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@danielmai