Fix for panic in fillGroupedVars #3781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pullrequest[bot]](https://avatars.githubusercontent.com/in/3434?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ A review job has been created and sent to the PullRequest network.
@pawanrawal you can click here to see the review status or cancel the code review job.
manishrjain
approved these changes
Aug 9, 2019
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @pawanrawal)
query/groupby.go, line 298 at r1 (raw file):
attr = child.Attr } if child.DestUIDs != nil && len(child.DestUIDs.Uids) != 0 {
Use child.DestUIDs.GetUids() which already takes care of DestUIDs being nil.
pawanrawal
added a commit
that referenced
this pull request
Aug 9, 2019
Use DestUIDs() function while accessing uids from child in GroupBy query. This fixes #3768.
pawanrawal
added a commit
that referenced
this pull request
Aug 9, 2019
Use DestUIDs() function while accessing uids from child in GroupBy query. This fixes #3768.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3768
For a uid child, DestUIDs can be nil if there were no source UIDs. This check was already happening in
formResultbut has been missed in this function. I am working on adding more code comments and trying to reduce the code duplication for the groupby code if possible in another PR.This change is