Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print sha256 of execuatble in the build details. #3828

Merged
merged 2 commits into from
Aug 21, 2019
Merged

Print sha256 of execuatble in the build details. #3828

merged 2 commits into from
Aug 21, 2019

Conversation

martinmr
Copy link
Contributor

@martinmr martinmr commented Aug 16, 2019 •
edited
Loading

Example output:

alpha1    | Dgraph version   : v1.0.12-rc3-672-gc2f2b0e5
alpha1    | Dgraph SHA-256   : e37235e5a7179572bf741020b49ace0530548b9c06c22a1ce6022a450f9f3a91
alpha1    | Commit SHA-1     : c2f2b0e5
alpha1    | Commit timestamp : 2019-08-16 10:45:17 -0700
alpha1    | Branch           : master
alpha1    | Go version       : go1.12.7

This change is Reviewable

@martinmr martinmr requested review from manishrjain and a team as code owners August 16, 2019 18:52
pullrequest[bot]
pullrequest bot reviewed Aug 16, 2019
View reviewed changes
Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ A review job has been created and sent to the PullRequest network.

@martinmr you can click here to see the review status or cancel the code review job.

pullrequest[bot]
pullrequest bot reviewed Aug 16, 2019
View reviewed changes
Copy link

@pullrequest pullrequest bot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 Message
✅ The description of this pull request is blank. Adding a high-level summary will help our reviewers provide better feedback.

golangcibot
golangcibot reviewed Aug 16, 2019
View reviewed changes
x/init.go Outdated Show resolved Hide resolved
pullrequest[bot]
pullrequest bot reviewed Aug 16, 2019
View reviewed changes
Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change here makes sense to me and looks clean. Thanks for adding a comment about errors being silenced/returning nil.

Reviewed with ❤️ by PullRequest

pullrequest[bot]
pullrequest bot reviewed Aug 16, 2019
View reviewed changes
Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✖️ This code review was cancelled. See Details

manishrjain
manishrjain approved these changes Aug 21, 2019
View reviewed changes
Copy link
Contributor

@manishrjain manishrjain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @martinmr)

@manishrjain manishrjain merged commit b985443 into master Aug 21, 2019
@manishrjain manishrjain deleted the martinmr/exec-sha-info branch August 21, 2019 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@golangcibot golangcibot golangcibot left review comments

@pullrequest pullrequest[bot] pullrequest[bot] left review comments

@manishrjain manishrjain manishrjain approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@martinmr @manishrjain @golangcibot