Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Reset alias after assigning it to UidCountAlias #3837

Merged
merged 1 commit into from
Aug 20, 2019

Conversation

pawanrawal
Copy link
Contributor

@pawanrawal pawanrawal commented Aug 20, 2019

This fixes #3814.


This change is Reviewable

@pawanrawal pawanrawal requested review from manishrjain and a team as code owners August 20, 2019 07:53
@pawanrawal pawanrawal changed the title Reset alias after assigning it to UidCountAlias Bugfix: Reset alias after assigning it to UidCountAlias Aug 20, 2019
Copy link
Contributor

@manishrjain manishrjain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@pawanrawal pawanrawal merged commit a928df8 into master Aug 20, 2019
@pawanrawal pawanrawal deleted the pawan/fix-3814 branch August 22, 2019 00:06
@danielmai
Copy link
Contributor

@pawanrawal This bug also happens in v1.0.16. Let's cherry-pick this into release/v1.0 too.

pawanrawal added a commit that referenced this pull request Aug 29, 2019
@pawanrawal
Copy link
Contributor Author

Thanks for reminding @danielmai. I have cherry-picked it as part of ab269a5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Bug with count and Aliases.
3 participants