Add support for *API* required for Multiple Mutation

[mangalaman93]

Related to #3817

---

This change is 

[manishrjain]

Reviewed 17 of 17 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @mangalaman93)

---

edgraph/server.go, line 762 at r1 (raw file):

		return s.doMutate(ctx, req, true)
	}

Why not do the authorization here as was being done before? I'm not following the need for change in doQuery func.

[mangalaman93]

Reviewable status: 13 of 18 files reviewed, 2 unresolved discussions (waiting on @golangcibot and @manishrjain)

---

edgraph/access_ee.go, line 381 at r1 (raw file):

Previously, golangcibot (Bot from GolangCI) wrote…

File is not gofmt-ed with -s (from gofmt)

				{Set: createUserNQuads},

Done.

---

edgraph/server.go, line 762 at r1 (raw file):

Previously, manishrjain (Manish R Jain) wrote…

Why not do the authorization here as was being done before? I'm not following the need for change in doQuery func.

Because we need to call authorizeMutate or authorizeQuery depending upon whether it is a mutation or it is a query. I just added code to do authorization for query in Mutation. I don't want to refactor this code in this PR, will do it when I implement Multiple Mutation.

[manishrjain]

Reviewable status: 11 of 18 files reviewed, 3 unresolved discussions (waiting on @golangcibot, @mangalaman93, and @manishrjain)

---

dgraph/cmd/alpha/http.go, line 316 at r2 (raw file):

		mu := &api.Mutation{}
		req = &api.Request{Mutations: []*api.Mutation{mu}}

Move this closer to usage. So a few lines below.

---

edgraph/server.go, line 762 at r1 (raw file):

Previously, mangalaman93 (Aman Mangal) wrote…

Because we need to call authorizeMutate or authorizeQuery depending upon whether it is a mutation or it is a query. I just added code to do authorization for query in Mutation. I don't want to refactor this code in this PR, will do it when I implement Multiple Mutation.

You know that information here (whether it is a query or a mutation). Call the authorization code here. What am I missing?

[mangalaman93]

Reviewable status: 11 of 18 files reviewed, 3 unresolved discussions (waiting on @golangcibot, @mangalaman93, and @manishrjain)

---

edgraph/server.go, line 762 at r1 (raw file):

Previously, manishrjain (Manish R Jain) wrote…

You know that information here (whether it is a query or a mutation). Call the authorization code here. What am I missing?

I didn't want to refactor code in this PR. There will be a lot of refactoring work that I'd do in the PR for multiple mutation. Anyway, I can get authorization part in in this PR.

[manishrjain]

Reviewable status: 11 of 18 files reviewed, 3 unresolved discussions (waiting on @golangcibot, @mangalaman93, and @manishrjain)

---

edgraph/server.go, line 762 at r1 (raw file):

Previously, mangalaman93 (Aman Mangal) wrote…

I didn't want to refactor code in this PR. There will be a lot of refactoring work that I'd do in the PR for multiple mutation. Anyway, I can get authorization part in in this PR.

But, you introduced a bool in doQuery API. The comment is asking about removing it. How is that refactoring?

[manishrjain]

Make the changes and merge it.

Reviewed 7 of 7 files at r2.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @golangcibot and @mangalaman93)

---

edgraph/server.go, line 422 at r2 (raw file):

}

func (s *Server) doMutate(ctx context.Context, req *api.Request, authorize bool) (

Switch authorize to an enum.

---

edgraph/server.go, line 775 at r2 (raw file):

	}

	ctx, span := otrace.StartSpan(ctx, methodQuery)

Move it back to wherever it was.

[mangalaman93]

Reviewable status: 15 of 18 files reviewed, 4 unresolved discussions (waiting on @golangcibot and @manishrjain)

---

dgraph/cmd/alpha/http.go, line 316 at r2 (raw file):

Previously, manishrjain (Manish R Jain) wrote…

Move this closer to usage. So a few lines below.

I think we discussed this, req is defined outside the switch. And putting mu inside req makes more sense to do as soon as possible.

---

edgraph/server.go, line 422 at r2 (raw file):

Previously, manishrjain (Manish R Jain) wrote…

Switch authorize to an enum.

Done.

---

edgraph/server.go, line 775 at r2 (raw file):

Previously, manishrjain (Manish R Jain) wrote…

Move it back to wherever it was.

Done.

[manishrjain]

Got to merge!

Reviewed 4 of 4 files at r3.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @golangcibot)

[manishrjain]

I meant good to merge.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @golangcibot)