-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test scripts assume GOPATH layout #4155
Comments
Hey @adg where do you see that Dgraph is going to support modules? :) |
@lolcoolkat 0e73a57 |
@adg check my comment here #4146 (comment) Still getting the same error as before they added go module support. Any ideas? :P |
If you saw the same error before and after modules were added, then I don't think it's related to this issue. |
@danielmai do you know how to go about fixing this? I am guessing we could have a dgraph-root argument the same way we do for the jepsen test binary. |
Something like dgraph-root that refers to the root of the repo would work. The tests and the test scripts should no longer assume that Dgraph or anything other repos (like the benchmarks repo for data files) are in GOPATH. |
Closing since the issue it's been addressed |
Now that the project is being made to support modules, there are still some old GOPATH-isms that remain. In
test.sh
and some of the included scripts, there are assumptions that the repo will be checked out into$GOPATH/src/github.com/dgraph-io/dgraph
, when with modules it may be checked out anywhere.The text was updated successfully, but these errors were encountered: