Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test scripts assume GOPATH layout #4155

Closed
adg opened this issue Oct 10, 2019 · 7 comments
Closed

Test scripts assume GOPATH layout #4155

adg opened this issue Oct 10, 2019 · 7 comments
Labels
priority/P0 Critical issue that requires immediate attention.

Comments

@adg
Copy link

adg commented Oct 10, 2019

Now that the project is being made to support modules, there are still some old GOPATH-isms that remain. In test.sh and some of the included scripts, there are assumptions that the repo will be checked out into $GOPATH/src/github.com/dgraph-io/dgraph, when with modules it may be checked out anywhere.

@dihmeetree
Copy link
Contributor

Hey @adg where do you see that Dgraph is going to support modules? :)

@adg
Copy link
Author

adg commented Oct 10, 2019

@lolcoolkat 0e73a57

@dihmeetree
Copy link
Contributor

@adg check my comment here #4146 (comment)

Still getting the same error as before they added go module support. Any ideas? :P

@adg
Copy link
Author

adg commented Oct 10, 2019

If you saw the same error before and after modules were added, then I don't think it's related to this issue.

@manishrjain manishrjain added the priority/P0 Critical issue that requires immediate attention. label Oct 15, 2019
@martinmr
Copy link
Contributor

@danielmai do you know how to go about fixing this? I am guessing we could have a dgraph-root argument the same way we do for the jepsen test binary.

@danielmai
Copy link
Contributor

Something like dgraph-root that refers to the root of the repo would work. The tests and the test scripts should no longer assume that Dgraph or anything other repos (like the benchmarks repo for data files) are in GOPATH.

@martinmr
Copy link
Contributor

Closing since the issue it's been addressed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/P0 Critical issue that requires immediate attention.
Development

No branches or pull requests

5 participants