Added RegExp parsing after GraphQL variable subsituition #4230
+60
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshil-goel
requested review from
manishrjain,
pawanrawal and
a team
as code owners
mangalaman93
approved these changes
Nov 11, 2019
manishrjain
approved these changes
Nov 12, 2019
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @harshil-goel and @pawanrawal)
go.mod, line 59 at r1 (raw file):
google.golang.org/genproto v0.0.0-20190516172635-bb713bdc0e52 // indirect google.golang.org/grpc v1.23.0 gopkg.in/DATA-DOG/go-sqlmock.v1 v1.3.0 // indirect
Do we need this?
go.sum, line 328 at r1 (raw file):
google.golang.org/grpc v1.23.0 h1:AzbTB6ux+okLTzP8Ru1Xs41C303zdcfEht7MQnYJt5A= google.golang.org/grpc v1.23.0/go.mod h1:Y5yQAOtifL1yxbo5wqy6BxZv8vAUGQwXBOALyacEbxg= gopkg.in/DATA-DOG/go-sqlmock.v1 v1.3.0 h1:FVCohIoYO7IJoDDVpV2pdq7SgrMH6wHnuTyrdrxJNoY=
Can you check if you need this thing?
gql/parser.go, line 454 at r1 (raw file):
_, ok := vmap[v.Value] if f.Func.Name == "regexp" && ok {
Add a comment here that we need to parse the regexp after substituting it from a GraphQL Variable.
harshil-goel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3268
Currently, after GraphQL variables were being substituted, RegExp was not being parsed. This PR adds parsing after the substitution of variables.
This change is