Fix Levenshtein distance calculation with match function.

[danielmai]

Fixes #4494.

We try to be smart about calculating the Levenshtein distance by short-circuiting the calculation based on the max-allowed distance, but that ends up returning incorrect distances.

• Remove max argument
• Fix and update tests.

---

This change is 

[martinmr]

Just one minor comment but it

Reviewed 2 of 2 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @danielmai and @manishrjain)

---

worker/match.go, line 32 at r1 (raw file):

// required to change one word into the other.
//
// This implemention is optimized to use O(min(m,n)) space and is based on the

Is this comment still true after the changes?

[martinmr]

approved

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @danielmai and @manishrjain)

[danielmai]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @manishrjain and @martinmr)

---

worker/match.go, line 32 at r1 (raw file):

Previously, martinmr (Martin Martinez Rivera) wrote…

Is this comment still true after the changes?

Yup, because the column array is created.

[campoy]

Reviewed 2 of 2 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @manishrjain and @martinmr)