Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include the total number of touched nodes in the query metrics. #5073

Merged
merged 1 commit into from
Apr 1, 2020

Conversation

martinmr
Copy link
Contributor

@martinmr martinmr commented Apr 1, 2020

Total is stored under a key called "_total".


This change is Reviewable

Total is stored under a key called "_total".
@martinmr martinmr requested review from manishrjain, pawanrawal and a team as code owners April 1, 2020 00:40
Copy link
Contributor

@manishrjain manishrjain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @pawanrawal)

@martinmr martinmr merged commit e3118ec into master Apr 1, 2020
@martinmr martinmr deleted the martinmr/total-uids branch April 1, 2020 22:33
@danielmai
Copy link
Contributor

If there was a predicate named _total, then this total would conflict with that predicate's num uid count.

We should put the total as another key (called num_uids_total) under metrics:

{
  "metrics": {
    "num_uids": {
      "director.film": 7,
      "name": 46
    }
    "num_uids_total": 53
  }
}

danielmai pushed a commit that referenced this pull request Apr 24, 2020
danielmai pushed a commit that referenced this pull request Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants