-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to apply enterprise license at zero's startup. #5170
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r1, 1 of 1 files at r2, 1 of 1 files at r3, 1 of 1 files at r4.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @manishrjain, @martinmr, and @MichaelJCompton)
dgraph/cmd/zero/license.go, line 41 at r4 (raw file):
} func (st *state) applyLicenceFile(path string) error {
applyLicenseFile (spelling)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 2 of 4 files reviewed, 3 unresolved discussions (waiting on @danielmai, @golangcibot, @manishrjain, and @MichaelJCompton)
dgraph/cmd/zero/license.go, line 41 at r4 (raw file):
Previously, danielmai (Daniel Mai) wrote…
applyLicenseFile (spelling)
Done.
dgraph/cmd/zero/license_ee.go, line 138 at r1 (raw file):
Previously, golangcibot (Bot from GolangCI) wrote…
File is not
gofmt
-ed with-s
(fromgofmt
)content, err := ioutil.ReadFile(path) if err != nil {
Done.
dgraph/cmd/zero/license_ee.go, line 138 at r2 (raw file):
Previously, golangcibot (Bot from GolangCI) wrote…
File is not
gofmt
-ed with-s
(fromgofmt
)content, err := ioutil.ReadFile(path) if err != nil {
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please cherry-pick to release/v20.03 too.
Reviewed 2 of 2 files at r5.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @danielmai, @golangcibot, @manishrjain, and @MichaelJCompton)
Cherry-picked it into the release branch. |
GitHub Issue or Jira number.
https://dgraph.atlassian.net/browse/DGRAPH-1218
Affected releases.
20.03.1
Changelog tags.
Added
Please indicate if this is a breaking change.
No
Please indicate if this is an enterprise feature.
Yes
Please indicate if documentation needs to be updated.
Yes. The changes needed are already included in this PR.
Please indicate if end to end testing is needed.
No
This change is
Docs Preview: