release/v1.2: Support comma separated list of zero addresses in alpha (#5116) #5258
+23
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, alpha supports specifying only a single zero instance address via the `--zero` flag in `dgraph alpha` command. This commit adds supports for a comma-separated list of `zero` addresses in `dgraph alpha` so that any zero address can be used from the list of zero addresses if one of them is unavailable. We'll pick zero addresses starting from the first one in the list and try to establish a connection to it. If it fails, we'll pick the next zero address. The `dgraph bulk/live` command accepts only a single zero address. The comma-separated list is only for `dgraph alpha` command. (cherry picked from commit 82adb16)
martinmr
reviewed
Apr 21, 2020
There was a problem hiding this comment.
Reviewable status: 0 of 5 files reviewed, all discussions resolved (waiting on @manishrjain)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA- DGRAPH-1132
Currently, alpha supports specifying only a single zero instance
address via the
--zeroflag indgraph alphacommand. This commitadds supports for a comma-separated list of
zeroaddresses indgraph alphaso that any zero address can be used from the listof zero addresses if one of them is unavailable.
We'll pick zero addresses starting from the first one in the list and
try to establish a connection to it. If it fails, we'll pick
the next zero address.
The
dgraph bulk/livecommand accepts only a single zero address.The comma-separated list is only for
dgraph alphacommand.(cherry picked from commit 82adb16)
This change is
Docs Preview: