Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove noise logs in tablet move #5333

Merged
merged 4 commits into from
Apr 29, 2020

Conversation

all-seeing-code
Copy link
Contributor

@all-seeing-code all-seeing-code commented Apr 29, 2020

When move tablets are running to different groups the whole stack trace can show up in the Zero log, which doesn't kill the zero but makes it look like an issue. This change edits the message to prevent logging the stack trace.

Zero Logs (Before):

E0429 16:41:56.818326     340 raft.go:352] While applying tablet proposal: Tablet is already being served
github.com/dgraph-io/dgraph/dgraph/cmd/zero.init
	/home/alvis/go/src/github.com/dgraph-io/dgraph/dgraph/cmd/zero/raft.go:161
runtime.doInit
	/usr/local/go/src/runtime/proc.go:5414
runtime.doInit
	/usr/local/go/src/runtime/proc.go:5409
runtime.doInit
	/usr/local/go/src/runtime/proc.go:5409
runtime.doInit
	/usr/local/go/src/runtime/proc.go:5409
runtime.doInit
	/usr/local/go/src/runtime/proc.go:5409
runtime.main
	/usr/local/go/src/runtime/proc.go:190
runtime.goexit
	/usr/local/go/src/runtime/asm_amd64.s:1373

Zero Logs (After)

E0429 17:44:14.433879    3184 raft.go:352] While applying tablet proposal: Tablet is already being served
E0429 17:44:14.433918    3184 raft.go:707] While applying proposal: Tablet is already being served

Fixes: DGRAPH-1141


This change is Reviewable

Copy link
Contributor

@martinmr martinmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @manishrjain)

Copy link
Contributor

@manishrjain manishrjain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ashish-goswami)

@all-seeing-code all-seeing-code merged commit 0cd1e4d into master Apr 29, 2020
all-seeing-code added a commit that referenced this pull request Jun 8, 2020
all-seeing-code added a commit that referenced this pull request Jun 8, 2020
all-seeing-code added a commit that referenced this pull request Jun 9, 2020
all-seeing-code added a commit that referenced this pull request Jun 9, 2020
dna2github pushed a commit to dna2fork/dgraph that referenced this pull request Jul 18, 2020
@all-seeing-code all-seeing-code deleted the anurags92/noisyLogsinTabletMove branch September 24, 2020 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants