Fix protobuf headers check. #5381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If installed from a package manager, the header files will be at /usr/include not /usr/local/include. This change fixes the check by looking at both places and including them in the call to protoc.
danielmai
approved these changes
May 8, 2020
There was a problem hiding this comment.
If there's a way to remove these checks completely, I'm all for it.
This does work, so
Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @danielmai and @manishrjain)
danielmai
approved these changes
May 8, 2020
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @manishrjain)
martinmr
added a commit
that referenced
this pull request
May 15, 2020
If installed from a package manager, the header files will be at /usr/include not /usr/local/include. This change fixes the check by looking at both places and including them in the call to protoc.
martinmr
added a commit
that referenced
this pull request
May 15, 2020
If installed from a package manager, the header files will be at /usr/include not /usr/local/include. This change fixes the check by looking at both places and including them in the call to protoc.
dna2github
pushed a commit
to dna2fork/dgraph
that referenced
this pull request
Jul 18, 2020
If installed from a package manager, the header files will be at /usr/include not /usr/local/include. This change fixes the check by looking at both places and including them in the call to protoc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If installed from a package manager, the header files will be at
/usr/include not /usr/local/include.
This change fixes the check by looking at both places and including
them in the call to protoc.
This change is