Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release/v1.2 K shortest paths queries fix and documentation update #5596

Merged
merged 3 commits into from
Jun 9, 2020
Merged

release/v1.2 K shortest paths queries fix and documentation update #5596

merged 3 commits into from
Jun 9, 2020

Conversation

all-seeing-code
Copy link
Contributor

@all-seeing-code all-seeing-code commented Jun 8, 2020 •
edited by dgraph-bot
Loading

Fixes #5426, #5410, #4861
Fixes DGRAPH-1258 DGRAPH-794 DGRAPH-1369

This change is Reviewable

Docs Preview: Dgraph Preview

@all-seeing-code
K-Shortest path query fix (#5410)
b091e93 
* Bug fix for depth parameter
* Handle cycles in K - Shortest path queries

(cherry picked from commit 6332254)
@all-seeing-code
Edit test cases to remove flaky behavior (#5464)
27ea4d1 
(cherry picked from commit bae2b1b)
@all-seeing-code
Added details of Shortest path queries in documentation (#5533)
ee679fd 
(cherry picked from commit abb57c0)
@all-seeing-code all-seeing-code changed the title K shortest paths queries fix and documentation update release/v1.2 K shortest paths queries fix and documentation update Jun 8, 2020
martinmr
martinmr approved these changes Jun 8, 2020
View reviewed changes
Copy link
Contributor

@martinmr martinmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 4 files reviewed, all discussions resolved (waiting on @danielmai, @MichaelJCompton, and @pawanrawal)

martinmr
martinmr approved these changes Jun 8, 2020
View reviewed changes
Copy link
Contributor

@martinmr martinmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @danielmai, @MichaelJCompton, and @pawanrawal)

@all-seeing-code all-seeing-code merged commit bfc46c2 into release/v1.2 Jun 9, 2020
@all-seeing-code all-seeing-code deleted the anurags92/KPathFixesCherryPick_v1 branch July 27, 2020 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinmr martinmr martinmr approved these changes

@danielmai danielmai Awaiting requested review from danielmai

@MichaelJCompton MichaelJCompton Awaiting requested review from MichaelJCompton

@pawanrawal pawanrawal Awaiting requested review from pawanrawal

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@all-seeing-code @martinmr