Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release/v20.03: Update badger 06/09/2020 #5616

Merged

Conversation

dgraph-bot
Copy link
Contributor

@dgraph-bot dgraph-bot commented Jun 9, 2020

This PR updates badger. The important changes are

KeepL0InMemory -> Set to false (badger default)
DetectConflicts -> Set to false

This change is Reviewable

Docs Preview: Dgraph Preview

@dgraph-bot dgraph-bot requested review from manishrjain and a team as code owners June 9, 2020 23:11
@jarifibrahim jarifibrahim self-assigned this Jun 10, 2020
Copy link
Contributor

@jarifibrahim jarifibrahim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This update contains conflict detection changes in badger. We need to disable the flag.

Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @manishrjain)

Copy link
Contributor

@jarifibrahim jarifibrahim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 3 files reviewed, all discussions resolved (waiting on @manishrjain)

@jarifibrahim jarifibrahim merged commit a374a1a into release/v20.03 Jun 15, 2020
@jarifibrahim jarifibrahim deleted the dgraph-bot/release/v20.03-update-06/09/2020 branch June 15, 2020 13:40
@peter-hartmann-emrsn
Copy link

To decide if I want to include this fix into my testing, it'd be good to know what problem it'll fix.

@jarifibrahim
Copy link
Contributor

@peter-hartmann-emrsn There's the changelog of this PR. There are two important changes

  • KeepL0InMemory set to false -> This would allow dgraph to start faster in case of a crash.
  • Deleted/Expired keys in compaction -> This fixes a bug where deleted/expired keys were not purged from the system,

This description was generated using this script:

#!/bin/bash

set -e
GHORG=${GHORG:-dgraph-io}
GHREPO=${GHREPO:-badger}
cat <<EOF
This description was generated using this script:
\`\`\`sh
`cat $0`
\`\`\`
Invoked as:

    `echo GHORG=${GHORG} GHREPO=${GHREPO} $(basename $0) ${@:1}`

EOF
git log --oneline --reverse ${@:1} \
  | sed -E "s/^(\S{7}\s)//g" \
  | sed -E "s/([\s|\(| ])#([0-9]+)/\1${GHORG}\/${GHREPO}#\2/g" \

Invoked as:

GHORG=dgraph-io GHREPO=badger changes.sh e7b6e76f96e8...14386ac9b764

DefaultOptions: Set KeepL0InMemory to false (dgraph-io/badger#1345)
Add immudb to the project list (dgraph-io/badger#1341)
Iterator: Always add key to txn.reads (dgraph-io/badger#1328)
StreamWriter: Close head writer (dgraph-io/badger#1347)
Fix build on golang tip (dgraph-io/badger#1355)
Compaction: Expired keys and delete markers are never purged (dgraph-io/badger#1354)
Support disabling conflict detection (dgraph-io/badger#1344)
Tests: Do not leave behind state goroutines (dgraph-io/badger#1349)
Restore: Account for value size as well (dgraph-io/badger#1358)
GC: Consider size of value while rewriting (dgraph-io/badger#1357)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants