Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(release/v20.03) Fix facets response with normalize #5691

Merged
merged 9 commits into from
Jul 9, 2020

Conversation

ashish-goswami
Copy link
Contributor

@ashish-goswami ashish-goswami commented Jun 19, 2020

Fixes: #5241
Fixes: DGRAPH-1670

This PR is related to #5690. It issues with facets response when facets are retrieved with
@normalize directive. Below two cases are covered:

  1. Fixing facets response with uid/uid list predicates.
  2. Fixing facets response with scalard list predicates.

This change is Reviewable

Docs Preview: Dgraph Preview

Copy link
Contributor

@pawanrawal pawanrawal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @ashish-goswami)


query/query_facets_test.go, line 2209 at r1 (raw file):

		q(func: uid(0x1)) @normalize {
			name: name
			friend @facets(since) @normalize {

Can you add a test case for uid list at second level also since this change impacts uid list?


query/query_facets_test.go, line 2228 at r1 (raw file):

				},
				{
				"friend_name": "Glenn Rhee",

formatting is messed up

Copy link
Contributor Author

@ashish-goswami ashish-goswami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 2 files reviewed, 2 unresolved discussions (waiting on @pawanrawal)


query/query_facets_test.go, line 2209 at r1 (raw file):

Previously, pawanrawal (Pawan Rawal) wrote…

Can you add a test case for uid list at second level also since this change impacts uid list?

Done.


query/query_facets_test.go, line 2228 at r1 (raw file):

Previously, pawanrawal (Pawan Rawal) wrote…

formatting is messed up

Done.

@vvbalaji-dgraph vvbalaji-dgraph self-requested a review July 7, 2020 13:43
@ashish-goswami ashish-goswami merged commit 0c25a21 into release/v20.03 Jul 9, 2020
@ashish-goswami ashish-goswami deleted the ashish/v20.03-normalize branch July 9, 2020 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants