-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(release/v20.03) Fix facets response with normalize #5691
Conversation
(cherry picked from commit e8db04a)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @ashish-goswami)
query/query_facets_test.go, line 2209 at r1 (raw file):
q(func: uid(0x1)) @normalize { name: name friend @facets(since) @normalize {
Can you add a test case for uid list at second level also since this change impacts uid list?
query/query_facets_test.go, line 2228 at r1 (raw file):
}, { "friend_name": "Glenn Rhee",
formatting is messed up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 2 files reviewed, 2 unresolved discussions (waiting on @pawanrawal)
query/query_facets_test.go, line 2209 at r1 (raw file):
Previously, pawanrawal (Pawan Rawal) wrote…
Can you add a test case for uid list at second level also since this change impacts uid list?
Done.
query/query_facets_test.go, line 2228 at r1 (raw file):
Previously, pawanrawal (Pawan Rawal) wrote…
formatting is messed up
Done.
Fixes: #5241
Fixes: DGRAPH-1670
This PR is related to #5690. It issues with facets response when facets are retrieved with
@normalize
directive. Below two cases are covered:This change is
Docs Preview: