release/20.07- Rollup: Reduce memory consumption of the map (#5599) #5957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FIXES - DGRAPH-1613 The incremental roll-up uses a `map` to keep track of the keys that should be rolled up. The current implementation never clears the map which stores the keys. The existing algorithm is ``` If key is present or key was rolled up 10 seconds ago, perform roll up ``` we never clean up the map in the existing algorithm and as a result the map consumed a lot of memory ``` 3.77GB 32.51% 32.51% 3.93GB 33.95% github.com/dgraph-io/dgraph/posting.(*incrRollupi).Process ``` The proposed change will clean up the keys every 2 minutes and remove the keys that have not changed in the last 10 seconds. (cherry picked from commit b77c23c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original PR #5731 was closed because I couldn't start CI on that PR.
FIXES - DGRAPH-1613
The incremental roll-up uses a
mapto keep track of the keys that should berolled up. The current implementation never clears the map which stores the
keys. The existing algorithm is
we never clean up the map in the existing algorithm and as a result the map
consumed a lot of memory
The proposed change will clean up the keys every 2 minutes and remove the keys
that have not changed in the last 10 seconds.
(cherry picked from commit b77c23c)
This change is
Docs Preview: