feat(graphql): GQL Logging MW for admin query/mutation #6562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parasssh
requested review from
pawanrawal,
abhimanyusinghgaur and
MichaelJCompton
github-actions
bot
added
the
area/graphql
pawanrawal
approved these changes
Sep 28, 2020
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @abhimanyusinghgaur and @MichaelJCompton)
abhimanyusinghgaur
approved these changes
Sep 28, 2020
There was a problem hiding this comment.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @MichaelJCompton and @parasssh)
graphql/admin/admin.go, line 340 at r1 (raw file):
health
state
graphql/admin/admin.go, line 348 at r1 (raw file):
Quoted 7 lines of code…
// dgraph checks Guardian auth for health "queryUser": {resolve.IpWhitelistingMW4Query, resolve.LoggingMWQuery}, // dgraph checks Guardian auth for health "getGroup": {resolve.IpWhitelistingMW4Query, resolve.LoggingMWQuery}, // dgraph checks Guardian auth for health "getCurrentUser": {resolve.IpWhitelistingMW4Query, resolve.LoggingMWQuery}, // dgraph checks Guardian auth for health "getUser": {resolve.IpWhitelistingMW4Query, resolve.LoggingMWQuery}, // dgraph checks Guardian auth for health "querySchemaHistory": {resolve.IpWhitelistingMW4Query, resolve.LoggingMWQuery}, // dgraph checks Guardian auth for health "getAllowedCORSOrigins": {resolve.IpWhitelistingMW4Query, resolve.LoggingMWQuery}, // dgraph checks Guardian auth for health
unnecessary comments got added in these lines, I think.
parasssh
commented
Sep 28, 2020
There was a problem hiding this comment.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @abhimanyusinghgaur and @MichaelJCompton)
graphql/admin/admin.go, line 340 at r1 (raw file):
Previously, abhimanyusinghgaur (Abhimanyu Singh Gaur) wrote…
healthstate
Done.
graphql/admin/admin.go, line 348 at r1 (raw file):
Previously, abhimanyusinghgaur (Abhimanyu Singh Gaur) wrote…
// dgraph checks Guardian auth for health "queryUser": {resolve.IpWhitelistingMW4Query, resolve.LoggingMWQuery}, // dgraph checks Guardian auth for health "getGroup": {resolve.IpWhitelistingMW4Query, resolve.LoggingMWQuery}, // dgraph checks Guardian auth for health "getCurrentUser": {resolve.IpWhitelistingMW4Query, resolve.LoggingMWQuery}, // dgraph checks Guardian auth for health "getUser": {resolve.IpWhitelistingMW4Query, resolve.LoggingMWQuery}, // dgraph checks Guardian auth for health "querySchemaHistory": {resolve.IpWhitelistingMW4Query, resolve.LoggingMWQuery}, // dgraph checks Guardian auth for health "getAllowedCORSOrigins": {resolve.IpWhitelistingMW4Query, resolve.LoggingMWQuery}, // dgraph checks Guardian auth for healthunnecessary comments got added in these lines, I think.
Done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes GRAPHQL-352
This change is