fix(bulk): fixing bulk loader when encryption + mtls is enabled #7154
Conversation
aman-bansal
requested review from
manishrjain and
vvbalaji-dgraph
as code owners
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @aman-bansal, @manishrjain, and @vvbalaji-dgraph)
dgraph/cmd/bulk/reduce.go, line 134 at r1 (raw file):
x.WorkerConfig.TLSClientConfig = r.opt.ClientTLSConfig if !worker.EnterpriseEnabled() {
Can we do this check in run.go instead of waiting until reduce starts? That way we would've caught this issue earlier.
There was a problem hiding this comment.
Reviewed 2 of 3 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @aman-bansal, @manishrjain, and @vvbalaji-dgraph)
There was a problem hiding this comment.
Reviewed 1 of 1 files at r3.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @aman-bansal, @manishrjain, and @vvbalaji-dgraph)
* fixing bulk loader when encryption + mtls is enabled * making enterprise check early * making tls var localised
* fixing bulk loader when encryption + mtls is enabled * making enterprise check early * making tls var localised
… (#7155) * fixing bulk loader when encryption + mtls is enabled * making enterprise check early * making tls var localised
This change is