fix(GRAPHQL):[Breaking] Don't generate get query on interface if it doesn't have field of type ID and also disallow get query on field of type @id in inerface. #7158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JatinDev543
requested review from
MichaelJCompton and
pawanrawal
as code owners
github-actions
bot
added
the
area/graphql
pawanrawal
suggested changes
Dec 18, 2020
There was a problem hiding this comment.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @jatindevdg, @MichaelJCompton, and @pawanrawal)
graphql/schema/testdata/schemagen/output/interface-with-id-directive.graphql, line 455 at r1 (raw file):
type Query { getLibraryItem(refID: String!): LibraryItem
Is there also a test where interface has both id: ID! and a field with @id directive.
added test |
abhimanyusinghgaur
approved these changes
Dec 21, 2020
There was a problem hiding this comment.
Reviewable status: 0 of 4 files reviewed, 2 unresolved discussions (waiting on @jatindevdg, @MichaelJCompton, and @pawanrawal)
graphql/schema/gqlschema.go, line 1735 at r2 (raw file):
if (!hasIDField && defn.Kind == "INTERFACE") || (!hasIDField && !hasXIDField)
can be simplified to:
if !hasIDField && (defn.Kind == "INTERFACE" || !hasXIDField)
JatinDev543
added a commit
that referenced
this pull request
Jan 15, 2021
…oesn't have field of type ID and also disallow get query on field of type @id in inerface. (#7158) Fixes GRAPHQL-886 We were allowing get query on the field of type @id on the interface type. This causes an error in cases when interface is implemented by multiple types and they try to have same value for field of type @id. To resolve this we are disallowing get query on the interface if it doesn't have a field of type ID , and if we have both fields of type ID and @id then we don't allow get query on the field of type @id. (cherry picked from commit 96b1fa5)
JatinDev543
added a commit
that referenced
this pull request
Jan 15, 2021
…oesn't have field of type ID and also disallow get query on field of type @id in inerface. (#7158) (#7305) Fixes GRAPHQL-886 We were allowing get query on the field of type @id on the interface type. This causes an error in cases when interface is implemented by multiple types and they try to have same value for field of type @id. To resolve this we are disallowing get query on the interface if it doesn't have a field of type ID , and if we have both fields of type ID and @id then we don't allow get query on the field of type @id. (cherry picked from commit 96b1fa5)
JatinDev543
added a commit
that referenced
this pull request
Mar 18, 2021
Fixes GRAPHQL-1119 We had this bug fix PR #7158 that also went into 20.11 release branch which disallow id argument in get queries on interfaces. Because it was breaking change , we are now rolling back this change and mark it as deprecated, and change later. Orignal bug https://discuss.dgraph.io/t/id-directive-and-interfaces/11642 Workaround So, we have disallowed @id argument from get query on interface, but the normal query still have it. So, users can change their get queries with simple query as follows. Interface with @id field interface Foo { id: String! @id } We can change below query query{ getFoo(id:"test"){ id } } to query{ queryFoo(filter: {id:{eq: "test"}}){ id } } Related Posts https://discuss.dgraph.io/t/id-directive-and-interfaces/11642 https://discuss.dgraph.io/t/was-there-a-change-to-generated-queries-with-id-directives-in-v20-11-1/12591
aman-bansal
pushed a commit
that referenced
this pull request
Mar 25, 2021
Fixes GRAPHQL-1119 We had this bug fix PR #7158 that also went into 20.11 release branch which disallow id argument in get queries on interfaces. Because it was breaking change , we are now rolling back this change and mark it as deprecated, and change later. Orignal bug https://discuss.dgraph.io/t/id-directive-and-interfaces/11642 Workaround So, we have disallowed @id argument from get query on interface, but the normal query still have it. So, users can change their get queries with simple query as follows. Interface with @id field interface Foo { id: String! @id } We can change below query query{ getFoo(id:"test"){ id } } to query{ queryFoo(filter: {id:{eq: "test"}}){ id } } Related Posts https://discuss.dgraph.io/t/id-directive-and-interfaces/11642 https://discuss.dgraph.io/t/was-there-a-change-to-generated-queries-with-id-directives-in-v20-11-1/12591
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes GRAPHQL-886
We were allowing get query on the field of type
@idon the interface type. This causes an error in cases wheninterfaceis implemented by multiple types and they try to have same value for field of type@id.To resolve this we are disallowing get query on the interface if it doesn't have a field of type
ID, and if we have both fields of typeIDand@idthen we don't allow get query on the field of type@id.This change is