fix(bulk): save schemaMap after map phase #7188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajeetdsouza
changed the title
This reverts commit 744f812.
manishrjain
approved these changes
Jan 5, 2021
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @ajeetdsouza, @jarifibrahim, and @vvbalaji-dgraph)
dgraph/cmd/bulk/run.go, line 315 at r1 (raw file):
var bulkMeta pb.BulkMeta err = bulkMeta.Unmarshal(bulkMetaData)
if err = ..; err != nil
dgraph/cmd/bulk/run.go, line 337 at r1 (raw file):
} err = ioutil.WriteFile(bulkMetaPath, bulkMetaData, 0644) if err != nil {
and here.
ajeetdsouza
force-pushed
the
ajeet/bulk
branch
from
a3aa6ee
to
058d940
Compare
ajeetdsouza
added a commit
that referenced
this pull request
Jan 22, 2021
ajeetdsouza
added a commit
that referenced
this pull request
Jan 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes DGRAPH-2862.
The bulk loader currently loses the
schemaMapwhen the map and reduce phase are separated. This PR stores this data in a proto file so that it can resume correctly.This change is