fix(restore): reset acl accounts once restore is done if necessary #7202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aman-bansal
requested review from
manishrjain,
MichaelJCompton,
pawanrawal and
vvbalaji-dgraph
as code owners
github-actions
bot
added
the
area/graphql
jarifibrahim
approved these changes
Jan 5, 2021
aman-bansal
force-pushed
the
aman/restore_acl_fix
branch
from
76f496e
to
d1f39f4
Compare
aman-bansal
added a commit
that referenced
this pull request
Jan 12, 2021
…7202) * reset acl accounts once restore is done if necessary * handling restores with wait group * making wg to work with each proposal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reset the ACL accounts once the restore is complete. When we start the restore, it apply DROP_ALL mutation and thus deleting ACL accounts. It's a common across all the alter operation, where we reset ACL accounts once we have the DROP_ALL operation.
This change is