fix(raft): Unmarshal zero snapshot into pb.ZeroSnaphot #7244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarifibrahim
requested review from
manishrjain and
vvbalaji-dgraph
as code owners
jarifibrahim
requested review from
danielmai,
martinmr,
MichaelJCompton and
pawanrawal
as code owners
We recently made a change to how we store snapshots and it looks like we forgot to change that at one place.
jarifibrahim
force-pushed
the
ibrahim/zero-snapshot
branch
from
6e5aca5
to
16a676b
Compare
NamanJain8
approved these changes
Jan 5, 2021
manishrjain
reviewed
Jan 5, 2021
There was a problem hiding this comment.
This should be abandoned. We'd need to revert the fix that we had merged to master, which we failed to port to the v20.11 release branch.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @danielmai, @manishrjain, @martinmr, @MichaelJCompton, @pawanrawal, and @vvbalaji-dgraph)
manishrjain
approved these changes
Jan 5, 2021
There was a problem hiding this comment.
After discussion, we can merge this. But, then bring this state of code over to master to avoid a breaking change in the next release.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @danielmai, @martinmr, @MichaelJCompton, @pawanrawal, and @vvbalaji-dgraph)
jarifibrahim
pushed a commit
that referenced
this pull request
Jan 7, 2021
We recently made a change to how we store snapshots and it looks like we forgot to change that at one place. (cherry picked from commit 842bb3d)
jarifibrahim
pushed a commit
that referenced
this pull request
Jan 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently made a change to how we store snapshots and it looks like we
forgot to change that in one place.
Fixes DGRAPH-2897
This change is