fix(GraphQL): Fix auth-token propagation for HTTP endpoints resolved through GraphQL (GRAPHQL-946) #7245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhimanyusinghgaur
requested review from
manishrjain,
MichaelJCompton,
pawanrawal and
vvbalaji-dgraph
as code owners
github-actions
bot
added
the
area/graphql
pawanrawal
approved these changes
Jan 5, 2021
There was a problem hiding this comment.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @abhimanyusinghgaur, @manishrjain, @MichaelJCompton, @pawanrawal, and @vvbalaji-dgraph)
graphql/e2e/admin_auth/poorman_auth/admin_auth_test.go, line 93 at r1 (raw file):
resp, err := (&http.Client{}).Do(req) require.NoError(t, err) b, err := ioutil.ReadAll(resp.Body)
defer resp.Body.Close()
pawanrawal
approved these changes
Jan 5, 2021
There was a problem hiding this comment.
Also, cherry-pick into 20.11 and 20.07
Reviewed 2 of 2 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @abhimanyusinghgaur, @manishrjain, @MichaelJCompton, and @vvbalaji-dgraph)
abhimanyusinghgaur
added a commit
that referenced
this pull request
Jan 6, 2021
…through GraphQL (GRAPHQL-946) (#7245) Fixes [Discuss Issue](https://discuss.dgraph.io/t/alpha-problems-with-auth-token/12136). (cherry picked from commit 146c4f1)
abhimanyusinghgaur
added a commit
that referenced
this pull request
Jan 6, 2021
…through GraphQL (GRAPHQL-946) (#7245) Fixes [Discuss Issue](https://discuss.dgraph.io/t/alpha-problems-with-auth-token/12136). (cherry picked from commit 146c4f1) # Conflicts: # graphql/e2e/admin_auth/poorman_auth/admin_auth_test.go
This was referenced Jan 6, 2021
abhimanyusinghgaur
added a commit
that referenced
this pull request
Jan 7, 2021
…through GraphQL (GRAPHQL-946) (#7245) (#7251) Fixes [Discuss Issue](https://discuss.dgraph.io/t/alpha-problems-with-auth-token/12136). (cherry picked from commit 146c4f1)
abhimanyusinghgaur
added a commit
that referenced
this pull request
Jan 7, 2021
…through GraphQL (GRAPHQL-946) (#7245) (#7252) Fixes [Discuss Issue](https://discuss.dgraph.io/t/alpha-problems-with-auth-token/12136). (cherry picked from commit 146c4f1) # Conflicts: # graphql/e2e/admin_auth/poorman_auth/admin_auth_test.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Discuss Issue.
This change is