fix(dgraph): Fix dgraph crash on windows #7261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were two issues on windows 1. We were trying to delete a file with open file descriptors. This doesn't work on windows. The PR dgraph-io/ristretto#242 in ristretto fixes this. 2. We were using path.Join instead of filepath.Join. The path package is supposed to be used only on unix systems. In windows the "\" is the path separator instead of "/".
jarifibrahim
requested review from
manishrjain and
vvbalaji-dgraph
as code owners
NamanJain8
suggested changes
Jan 8, 2021
There was a problem hiding this comment.
Shouldn't we abandon usages of path then? For example at
Line 95 in d13e744
Also go.mod would need to be updated once ristretto PR is merged.
|
@NamanJain8 nice catch. I'll update all the occurrences of |
NamanJain8
approved these changes
Jan 11, 2021
|
✔️ Deploy preview for dgraph-docs ready! 🔨 Explore the source changes: 39441a0 🔍 Inspect the deploy logs: https://app.netlify.com/sites/dgraph-docs/deploys/5ffc94e8ff04fa00076dee9c 😎 Browse the preview: https://deploy-preview-7261--dgraph-docs.netlify.app |
jarifibrahim
pushed a commit
that referenced
this pull request
Jan 15, 2021
There were two issues on windows 1. We were trying to delete a file with open file descriptors. This doesn't work on windows. The PR dgraph-io/ristretto#242 in ristretto fixes this. 2. We were using path.Join instead of filepath.Join. The path package is supposed to be used only on Unix systems. In windows the "" is the path separator instead of "/". (cherry picked from commit 5aec243)
jarifibrahim
pushed a commit
that referenced
this pull request
Jan 15, 2021
There were two issues on windows 1. We were trying to delete a file with open file descriptors. This doesn't work on windows. The PR dgraph-io/ristretto#242 in ristretto fixes this. 2. We were using path.Join instead of filepath.Join. The path package is supposed to be used only on Unix systems. In windows the "" is the path separator instead of "/". (cherry picked from commit 5aec243)
thesophiaxu
added a commit
to unigraph-dev/dgraph
that referenced
this pull request
Jan 11, 2022
thesophiaxu
added a commit
to unigraph-dev/dgraph
that referenced
this pull request
Jan 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were two issues on windows
doesn't work on windows. The PR
fix(MmapFile): Close the fd before deleting the file ristretto#242 in ristretto fixes this.
supposed to be used only on unix systems. In windows the "" is the path
separator instead of "/".
This change is