perf(dgraph) - Use badger sinceTs in backups #7392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarifibrahim
requested review from
manishrjain and
vvbalaji-dgraph
as code owners
NamanJain8
reviewed
Feb 4, 2021
jarifibrahim
changed the title
jarifibrahim
commented
Feb 4, 2021
jarifibrahim
pushed a commit
that referenced
this pull request
Feb 16, 2021
The recent change #7392 improved the incremental backups but degraded the performance of full backups. This PR fixes that. With this PR, we use the thread local iterator only for the incremental backups. Using the thread local iterator for full backups causes a 10x slowdown in performance.
jarifibrahim
pushed a commit
that referenced
this pull request
Feb 18, 2021
The recent change #7392 improved the incremental backups but degraded the performance of full backups. This PR fixes that. With this PR, we use the thread local iterator only for the incremental backups. Using the thread local iterator for full backups causes a 10x slowdown in performance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves incremental backups.
We set the sinceTs in the stream framework to skip data that is below the sinceTs. Since the schema and type are written at timestamp 1, we need to separately process and store them.
Time taken to backup 21 million -> 1.11 minutes
Time taken to create an incremental backup with 2 new nquads
Master - 5.8 seconds
This PR - 1 second
Fixes DGRAPH-2958
This change is