fix(sort): Fix multi-sort with nils #7432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahsanbarkati
requested review from
manishrjain and
vvbalaji-dgraph
as code owners
pawanrawal
approved these changes
Feb 17, 2021
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @manishrjain and @vvbalaji-dgraph)
ahsanbarkati
added a commit
that referenced
this pull request
Feb 17, 2021
Fix the behavior of multi-sort. All the nil values are appended at the end of the result irrespective of ascending or descending sort. This change also fixes a bug due to not appending the nil values in the values list, corresponding to the UIDs appended in the UID list with nil predicates. (cherry picked from commit 2c7de57)
aman-bansal
pushed a commit
that referenced
this pull request
Feb 17, 2021
Fix the behavior of multi-sort. All the nil values are appended at the end of the result irrespective of ascending or descending sort. This change also fixes a bug due to not appending the nil values in the values list, corresponding to the UIDs appended in the UID list with nil predicates. (cherry picked from commit 2c7de57)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multi-sort with some predicates with null values was broken (Discuss post). This PR fixes it.
Tests are also added for multi-sort with null values.
This change is