Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(GraphQL): Fix Upsert with Multiple IDs #7472

Merged
merged 1 commit into from
Feb 23, 2021
Merged

Fix(GraphQL): Fix Upsert with Multiple IDs #7472

merged 1 commit into from
Feb 23, 2021

Conversation

vmrajas
Copy link
Contributor

@vmrajas vmrajas commented Feb 23, 2021

Currently, if a node with one of the supplied XIDs does not exist also gets updated during Add with Upsert. This should not happen. Value of any of the XIDs should not change during an Upsert Mutation. This PR fixes this.

Testing:

  1. yaml test added in add_mutation_test.yaml .

This change is Reviewable

@github-actions github-actions bot added the area/graphql Issues related to GraphQL support on Dgraph. label Feb 23, 2021
Copy link
Contributor

@JatinDev543 JatinDev543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @abhimanyusinghgaur and @pawanrawal)

@vmrajas vmrajas merged commit f367c35 into master Feb 23, 2021
@vmrajas vmrajas deleted the GRAPHQL-1047 branch February 23, 2021 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/graphql Issues related to GraphQL support on Dgraph.
Development

Successfully merging this pull request may close these issues.

2 participants