Fix(GraphQL): Change variable name generation from Type<Num> to Type_<Num> #7556
+1,357
−1,212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area/graphql
vmrajas
changed the title
abhimanyusinghgaur
approved these changes
Mar 12, 2021
There was a problem hiding this comment.
Reviewed 15 of 15 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @pawanrawal)
aman-bansal
pushed a commit
that referenced
this pull request
Mar 15, 2021
…<Num> (#7556) * Change variable name generation from Type<Num> to Type_<Num> * Add yaml test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
While rewriting GraphQL queries and mutations to DQL, different variable names are used to generate query names, blank node names. Exam ple: While rewriting
addProjectmutation, the variableProject1is used while writing existence queries. This is problematic as same variable name could get generated for two different nodes likePerson1+1andPerson+11, both generatingPerson11.To avoid this, this PR adds
_in variable generation between type name and number.Testing:
Added test to add_mutation_test.yaml
Fixes GRAPHQL-1079
This change is