Don't start a learner node with no peers #7582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahsanbarkati
commented
Mar 16, 2021
| @@ -1742,6 +1743,10 @@ func (n *node) InitAndStartNode() { | |||
| } | |||
| } | |||
|
|
|||
| if n.RaftContext.IsLearner && !hasPeer { | |||
There was a problem hiding this comment.
For the case of restart, should we check again after making connections to nodes in ConfState? I don't know why it is required.
There was a problem hiding this comment.
I suggest we keep this here for now.
ahsanbarkati
requested review from
manishrjain and
vvbalaji-dgraph
as code owners
jarifibrahim
approved these changes
Mar 17, 2021
| @@ -1742,6 +1743,10 @@ func (n *node) InitAndStartNode() { | |||
| } | |||
| } | |||
|
|
|||
| if n.RaftContext.IsLearner && !hasPeer { | |||
There was a problem hiding this comment.
I suggest we keep this here for now.
aman-bansal
pushed a commit
that referenced
this pull request
Mar 25, 2021
When a learner node starts and there is no alpha peer then it behaves like a normal mode. This change causes it to crash itself if it has no peer alpha nodes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a learner node starts and there is no alpha peer then it promotes itself to a normal mode.
This PR makes it crash itself in this case.
This change is