fix(upgrade): make upgrade tool to work with non-acl cluster #7674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NamanJain8
requested review from
manishrjain and
vvbalaji-dgraph
as code owners
NamanJain8
force-pushed
the
naman/upgrade-non-acl
branch
from
09cabf7
to
2209833
Compare
abhimanyusinghgaur
approved these changes
Apr 1, 2021
There was a problem hiding this comment.
Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @manishrjain, @NamanJain8, and @vvbalaji-dgraph)
upgrade/change_v21.03.0.go, line 155 at r1 (raw file):
len(Upgrade.Conf.GetString(user)) > 0
maybe put this in a function: hasAclCreds() bool and use that at all the 3 places.
aman-bansal
pushed a commit
that referenced
this pull request
Apr 8, 2021
For the upgrade in versions <= 20.07, dgraph upgrade tool updates the acl relates data. Hence, it had --acl flag. With the update of the upgrade tool for 21.03, it should work without ACL as well. This PR adds that support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the upgrade in versions <= 20.07,
dgraph upgradetool updates the acl relates data. Hence, it had--aclflag. With the update of the upgrade tool for 21.03, it should work without ACL as well. This PR adds that support.This change is