Feat(Multi-tenancy): Add namespaces field to state #7808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmrajas
requested review from
manishrjain,
pawanrawal and
vvbalaji-dgraph
as code owners
github-actions
bot
added
the
area/graphql
abhimanyusinghgaur
approved these changes
May 13, 2021
NamanJain8
approved these changes
May 13, 2021
There was a problem hiding this comment.
Reviewable status: 0 of 4 files reviewed, 3 unresolved discussions (waiting on @abhimanyusinghgaur, @manishrjain, @pawanrawal, @vmrajas, and @vvbalaji-dgraph)
graphql/admin/admin.go, line 153 at r1 (raw file):
cid: String license: License namespaces: [UInt64]
Would be good to have a comment that proto's membership state does not contain namespaces.
graphql/admin/state.go, line 83 at r1 (raw file):
// namespaces stores set of namespaces namespaces := make(map[uint64]bool)
Use map[uint64]struct{} see https://dave.cheney.net/2014/03/25/the-empty-struct
x/keys.go, line 122 at r1 (raw file):
func ExtractNamespaceFromPredicate(predicate string) (uint64, error) { splitString := strings.Split(predicate, "-")
This function won't be needed after the JSON marshal fix. I will remove that when I merge my change #7817
vmrajas
changed the title
OmarAyo
pushed a commit
that referenced
this pull request
Jun 30, 2021
* Add namespaces to state * Add tests * Fix golint errors * Address Naman's comments (cherry picked from commit d2bd832)
OmarAyo
pushed a commit
that referenced
this pull request
Jun 30, 2021
* Add namespaces to state * Add tests * Fix golint errors * Address Naman's comments (cherry picked from commit d2bd832)
OmarAyo
added a commit
that referenced
this pull request
Jun 30, 2021
Motivation: Currently, there is no way to query namespaces. This adds namespaces field to state. This field can be used to query list of namespaces. Note that this will output list of namespace only in case the user is an admin user (guardians of galaxy). In all other cases, it will return an empty list. (cherry picked from commit d2bd832) Co-authored-by: vmrajas <rajas@dgraph.io>
OmarAyo
added a commit
that referenced
this pull request
Jun 30, 2021
Motivation: Currently, there is no way to query namespaces. This adds namespaces field to state. This field can be used to query list of namespaces. Note that this will output list of namespace only in case the user is an admin user (guardians of galaxy). In all other cases, it will return an empty list. (cherry picked from commit d2bd832) Co-authored-by: vmrajas <rajas@dgraph.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Currently, there is no way to query namespaces. This adds namespaces field to state. This field can be used to query list of namespaces.
Note that this will output list of namespace only in case the user is an admin user (guardians of galaxy). In all other cases, it will return an empty list.
Testing:
Fixes DGRAPH-3310
This change is