fix(lambda): monitor lambda server, fix performance issue, remove lambda logs from extensions #8006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/graphql
aman-bansal
approved these changes
Aug 31, 2021
| go func(i int) { | ||
| for { | ||
| select { | ||
| case <-closer.HasBeenClosed(): | ||
| break | ||
| return |
There was a problem hiding this comment.
we will never reach here untill the process is running. I believe thats the expected behavior. Just wanted to point this out
There was a problem hiding this comment.
Correct. This is added so that alpha does not try to restart the lambda while the alpha is being shut down.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By running lambda script in a new context adds a performance penalty.
This PR adds a health monitor in alpha that periodically pings lambda servers to check their responsiveness. The unresponsive lambda server ( configurable via
--lambda=restart-afterflag, default is10s) is restarted.Also, this PR removes the lambda logs from the GraphQL response's extension. Instead they are spit out in alpha logs itself with prefix
[LAMBDA-${ns}]This change is