-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(rollup): use NSplit API from sroar to improve rollup performance #8092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NamanJain8
force-pushed
the
naman/perf-split
branch
from
November 11, 2021 17:06
e2f2856
to
a56d6c4
Compare
NamanJain8
force-pushed
the
naman/perf-split
branch
from
November 17, 2021 09:41
3e0faa6
to
6ab63b6
Compare
NamanJain8
force-pushed
the
naman/perf-split
branch
from
November 24, 2021 17:15
fe3b376
to
703e778
Compare
In alpha max splits default value is probably missing. Secondly can we make default value of max-splits equal to nquad-limits. So that it wont affect currently running workflows for customers. They can set this variable to enhance the performance |
aman-bansal
approved these changes
Nov 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the performance of the rollups. Also, it fixes memory issues of the bulk loader.
Split
API from the sroar to split the bitmap (while doing rollup). This is an improvement over the recursive binary split that was very slow.HandoverSkipList
API instead ofWriteBatch
to avoid the memory constraints of doing a huge batch write.Also, it introduces
BitForbidPosting
that limits the capability to store large posting lists that generate splits of length greater than the--limit max-splits
flag. Once a posting list is marked as Forbidden it cannot be recovered.This change is