Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KeyToHash possibly letting key interfaces escape to heap #107

Closed
karlmcguire opened this issue Dec 2, 2019 · 2 comments
Closed

KeyToHash possibly letting key interfaces escape to heap #107

karlmcguire opened this issue Dec 2, 2019 · 2 comments
Labels
kind/bug Something is broken. priority/P1 Serious issue that requires eventual attention (can wait a bit) status/accepted We accept to work on it.

Comments

@karlmcguire
Copy link
Contributor

karlmcguire commented Dec 2, 2019 •
edited
Loading

As brought up in the performance Gopher channel, since we're using interface{} for keys, this call to keyToHash is probably letting the interface escape to heap.

Solution: switch over to string or []byte for public API calls.
@karlmcguire karlmcguire mentioned this issue Dec 13, 2019
Closed
@lgalatin lgalatin added the status/accepted We accept to work on it. label Jan 14, 2020
@martinmr
Copy link
Contributor

@karlmcguire should the change be for keys or keys and values?

@martinmr martinmr added kind/bug Something is broken. priority/P1 Serious issue that requires eventual attention (can wait a bit) labels Feb 21, 2020
This was referenced Feb 25, 2020
Closed
Closed
@minhaj-shakeel
Copy link
Contributor

Github issues have been deprecated.
This issue has been moved to discuss. You can follow the conversation there and also subscribe to updates by changing your notification preferences.

drawing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Something is broken. priority/P1 Serious issue that requires eventual attention (can wait a bit) status/accepted We accept to work on it.
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change public API to use byte arrays for keys. dgraph-io/ristretto
4 participants
@martinmr @karlmcguire @minhaj-shakeel @lgalatin