-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[performance] Improve the performance of damerau_levenshtein #32
Conversation
My tests show the new version is approximately 2.5 times faster than the old ones. Most of the gains come from using hashbrown for the hashmap.
Cargo bench before:
and after:
|
Hey, thanks. This looks awesome. My only concern is bumping the required Rust version to 1.31 since it was only released four months ago. Is that a requirement for hashbrown? |
yes, it's a requirement of hashbrown : https://github.com/Amanieu/hashbrown/blob/master/CHANGELOG.md |
Many crates depend on rust 1.31, since it marked the beginning of the 2018 edition. |
Sounds good. A project that can't upgrade yet for some reason can always use an older version. I published the change as v0.9.1. |
My tests show the new version is approximately 2.5 times faster than
the old one. Most of the gains come from using hashbrown for the
hashmap.