fix!: remove child process option #1545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnalborczyk
force-pushed
the
remove-child-process
branch
2 times, most recently
from
d87fdd6 to
0dacf7a
Compare
dnalborczyk
force-pushed
the
remove-child-process
branch
4 times, most recently
from
041a3a4 to
13ab6b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
--useChildProcessesis redundant, has no advantages, and can be replaced with the better option of usingworker threads, the current default. It's one less option and less code to maintain.the
child processoption also originated at a time whereworker threadsweren't available in node.js yet, and handler reloading in thein-processmode was buggy and leaking memory.BREAKING, next major release, v10
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):