fix: prevent overwriting host.docker.internal in wsl #1605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@frozenbonito we have some docker related tests which we are currently skipping unfortunately. 😞 I tried to fix those up some time ago, but wasn't quite sure about the intend for some of those. do you think you could have a look if you have some time? |
frozenbonito
deleted the
fix-accessibility-from-container-to-host-in-wsl
branch
|
@dnalborczyk
I would like to fix it. Do you mean docker-in-docker test? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR prevents overwriting
host.docker.internalhost in WSL environment.I added is-wsl for checking if the process is running inside WSL.
Motivation and Context
In WSL, it seems that the host is not reachable with the gateway ip adress of
bridgenetwork.For this reason,
--add-host host.docker.internal:${gatewayIp}does not work as expected.Docker for Windows supports
host.docker.internalnatively, so just avoid addinghost.docker.internaland it works.How Has This Been Tested?
This has been tested by running accessHost.test.js in WSL.