-
-
Notifications
You must be signed in to change notification settings - Fork 796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: convert multipart/form-data to base64 encoded payloads #1776
feat: convert multipart/form-data to base64 encoded payloads #1776
Conversation
hi @dnalborczyk! let me know what you and the other maintainers think of this PR, cheers! |
hi @dherault! could you or one of the maintainers have a look at this PR? thank you! |
thanks @DorianMazur I'll look at adding this to ApiGV1 in the meantime. I selfishly didn't do it cause I don't use V1 🤣 |
hi @DorianMazur I've added a fix for |
Rerun tests |
hi @DorianMazur! is everything ok here? |
hi @DorianMazur did you want more tests added to confirm everything is ok? |
Looks good! |
thank you @DorianMazur!! what's the ETA for a tagged version including this? |
Closing the loop, this was released in https://github.com/dherault/serverless-offline/releases/tag/v13.5.0 thanks @DorianMazur ! |
Description
AWS API Gateway V2 sets
isBase64Encoded: true
and Base64 encodesbody
when theContent-Type
ismultipart/form-data
.Here's an event I captured from CloudWatch logs:
Motivation and Context
Motivation is to have consistency with actual API Gateway V2.
How Has This Been Tested?
I added tests, but please let me know if you'd like to see more! Happy for any and all suggestions.